-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Helm Chart for new infrastructure #52
Conversation
Coverage report
Test suite run success0 tests passing in 0 suite. Report generated by 🧪jest coverage report action from bffc6ca |
repository: ghcr.io/fuellabs/fuel-explorer | ||
pullPolicy: Always | ||
# Overrides the image tag whose default is the chart appVersion. | ||
tag: "af1e196" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this tag refer to some deployed images inside the repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just a fallback. What gets deployed is set in the infrastructure repo https://github.com/FuelLabs/fuel-deployment-v2/pull/37/files - please see kustomize/environments/fuel-dev-2/fuel-apps/dev-fuel-explorer/release.yaml
line 18
.github/workflows/helm-publish.yml
Outdated
on: | ||
push: | ||
branches: | ||
- main | ||
pull_request: | ||
types: [opened, synchronize] | ||
release: | ||
types: [published] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this config, will the helm be published on every PR? should we make it just on the main branch? Or would this be capable of deploying preview envs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a good catch, thanks for the feedback. I just copied from your docker build pipeline. We should run this pipeline only if changes are made to helm/**
. I'll update the rules
No description provided.