Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Helm Chart for new infrastructure #52

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Conversation

liviudm
Copy link
Contributor

@liviudm liviudm commented Sep 26, 2023

No description provided.

@liviudm liviudm requested a review from luizstacio September 26, 2023 13:25
@liviudm liviudm self-assigned this Sep 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 0/0
🟢 Branches 100% 0/0
🟢 Functions 100% 0/0
🟢 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by 🧪jest coverage report action from bffc6ca

repository: ghcr.io/fuellabs/fuel-explorer
pullPolicy: Always
# Overrides the image tag whose default is the chart appVersion.
tag: "af1e196"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this tag refer to some deployed images inside the repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just a fallback. What gets deployed is set in the infrastructure repo https://github.com/FuelLabs/fuel-deployment-v2/pull/37/files - please see kustomize/environments/fuel-dev-2/fuel-apps/dev-fuel-explorer/release.yaml line 18

Comment on lines 3 to 10
on:
push:
branches:
- main
pull_request:
types: [opened, synchronize]
release:
types: [published]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this config, will the helm be published on every PR? should we make it just on the main branch? Or would this be capable of deploying preview envs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good catch, thanks for the feedback. I just copied from your docker build pipeline. We should run this pipeline only if changes are made to helm/**. I'll update the rules

@luizstacio luizstacio changed the title Add Helm Chart for new infrastructure feat: add Helm Chart for new infrastructure Sep 26, 2023
@luizstacio luizstacio merged commit 8f84974 into main Sep 26, 2023
6 checks passed
@luizstacio luizstacio deleted the ld/feat/helm-charts-v2 branch September 26, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants