Add push/pop instructions #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voxelot
reviewed
Jul 13, 2023
Voxelot
reviewed
Jul 13, 2023
xgreenx
reviewed
Aug 6, 2023
| try_update_stack_pointer(sp, ssp, hp, stack_range.words().end)?; | ||
|
|
||
| // Write the registers to the stack | ||
| let mut it = memory[stack_range.usizes()].chunks_exact_mut(8); |
There was a problem hiding this comment.
Is it possible to cross the heap here? Or is it not because we checked that inside of the try_update_stack_pointer?
There was a problem hiding this comment.
try_update_stack_pointer performs the check
fuel-vm/src/interpreter/memory.rs
Outdated
| let mut it = memory[stack_range.usizes()].chunks_exact_mut(8); | ||
| for (i, reg) in program_regs.segment(segment).iter().enumerate() { | ||
| if (bitmask & (1 << i)) != 0 { | ||
| it.next().unwrap().copy_from_slice(®.to_be_bytes()); |
There was a problem hiding this comment.
Could you use expect, please, with a description of why it is impossible?=)
fuel-vm/src/interpreter/memory.rs
Outdated
|
|
||
| // First update the new stack pointer, as that's the only error condition | ||
| let count = bitmask.count_ones(); | ||
| let stack_range = MemoryRange::new(*sp, (count as u64) * 8)?; |
There was a problem hiding this comment.
Suggested change
| let stack_range = MemoryRange::new(*sp, (count as u64) * 8)?; | |
| let stack_range = MemoryRange::new(*sp, count * 8)?; |
There was a problem hiding this comment.
That will not work; u32 doesn't implement ToAddr (unless we expand the implementation to cover it). The as-cast here is extending u32 returned by count_ones(), and is complely harmless. I'm replacing it with a .into() cast anyway, so it looks less suspicious.
xgreenx
approved these changes
Aug 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting with push/pop opcodes. See spec PR FuelLabs/fuel-specs#499 and spec issue FuelLabs/fuel-specs#407