Bugfixes found during chatting with Auditors on July 7th #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s` structure. Check that the contract in inputs for `CROO` and `CSIZ`. Fixed the bug with `total_code_size`. Fixed the bug with incorrect gas charging per unit.
xgreenx
added
bug
bvrooman
reviewed
Jul 11, 2023
fuel-vm/src/interpreter.rs
Outdated
| @@ -461,3 +461,27 @@ impl CheckedMetadata for CreateCheckedMetadata { | |||
| self.gas_used_by_predicates = gas_used; | |||
| } | |||
| } | |||
|
|
|||
| pub(crate) struct TouchedContracts<'vm, I> { | |||
There was a problem hiding this comment.
I think the idea of centralizing the location where we check the list of input contracts is a good abstraction. However, I think touch is a bit of a misleading name. In the context of software, touch usually means to create a file/modify its timestamp (see https://www.geeksforgeeks.org/touch-command-in-linux-with-examples/). Here, you're using touch to panic if the contract doesn't exist. From a naming perspective, that is almost the opposite of what I would expect it to do.
What about calling the struct something like InputContracts<..> and changing touch to something like check?
Voxelot
previously approved these changes
Jul 11, 2023
Voxelot
approved these changes
Jul 11, 2023
bvrooman
approved these changes
Jul 11, 2023
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified the check that the
ContractIdin inputs byTouchedContractsstructure.Check that the contract is in inputs for
CROOandCSIZ.Fixed the bug with
total_code_size.Fixed the bug with incorrect gas charging per unit.