Return correct PanicReason on memory-related panics #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
changed the title
xgreenx
reviewed
Jul 26, 2023
Voxelot
reviewed
Jul 27, 2023
Voxelot
reviewed
Jul 27, 2023
Voxelot
reviewed
Aug 3, 2023
| let contract_id = ContractId::from_bytes_ref(contract_id); | ||
|
|
||
| self.input_contracts.check(contract_id)?; | ||
| self.input_contracts.check(&contract_id)?; |
There was a problem hiding this comment.
maybe we should perform this validation before filling the memory with zeros? It gives us a way to bail out of execution earlier before performing a potentially large memset.
Dentosal
added a commit
to FuelLabs/fuel-specs
that referenced
this pull request
Aug 3, 2023
The configuration value for it was fixed to `MEM_MAX_ACCESS_SIZE = VM_MAX_RAM`. The rule against exceeding `VM_MAX_RAM` always triggers first. See FuelLabs/fuel-vm#511 (comment) and the PR in general for the removal from `fuel-vm`.
Voxelot
previously approved these changes
Aug 5, 2023
# Conflicts: # fuel-vm/src/interpreter/contract.rs
xgreenx
approved these changes
Aug 6, 2023
Merged
This was referenced Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38. Refactors the error handling code of multiple functions to leverage
MemoryRangeeven more. Changes multiple panic reasons to be more accurate.