fix(fuzz_coverage): Don't specify compiler version to avoid raw profile version mismatch #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netrome
requested review from
xgreenx,
Dentosal,
MitchTurner and
Voxelot
as code owners
xgreenx
approved these changes
Oct 17, 2024
Dentosal
approved these changes
Oct 17, 2024
acerone85
approved these changes
Oct 17, 2024
netrome
deleted the
856-investigate-missing-fuzz-coverage-reports-in-ci
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the missing coverage reports by removing an unnecessary nightly version pinning. As the OSS-FUZZ base builder image already comes with the latest rust nightly compiler (docs https://google.github.io/oss-fuzz/getting-started/new-project-guide/rust-lang/#dockerfile), this version pinning which causes a version conflict in the generated raw profile file.
The fix is to simply remove the pinned compiler version from the dockerfile.
This has been tested and a successful CI run can be observed here, with the generated coverage reports visible here.