Add a separate error for nonexistent contract input #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
changed the title
Dentosal
changed the title
Dentosal
requested review from
xgreenx,
MitchTurner and
Voxelot
as code owners
MitchTurner
reviewed
Nov 8, 2024
AurelienFT
previously approved these changes
Nov 9, 2024
xgreenx
reviewed
Nov 27, 2024
| @@ -905,7 +905,7 @@ where | |||
| false | |||
| } | |||
| }) { | |||
| return Err(InterpreterError::Panic(PanicReason::ContractNotInInputs)); | |||
| return Err(InterpreterError::Panic(PanicReason::InputContractDoesNotExist)); | |||
There was a problem hiding this comment.
I know that is it not possible to call contract from non Script transaction, but it looks like we need to move this check to the begin of the run function and return an error if contract doesn't exist regardless of the transaction type.
…ut-contract # Conflicts: # CHANGELOG.md # fuel-asm/src/panic_reason.rs
Added an explicit `match` statement to not forget in the future to add handling of a new variants of the transactions.
xgreenx
approved these changes
Dec 2, 2024
AurelienFT
approved these changes
Dec 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging a contract error with @matt-user, we noticed that trying to transfer to zero address produced a weird error message. Instead of saying "contract was in inputs, but doesn't exist", the message was just "contract not in inputs". This PR creates a separate error for that. It's technically a breaking change, since we change error to be another error.
Checklist
Before requesting review