Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace derivative by educe #876

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Replace derivative by educe #876

merged 3 commits into from
Dec 6, 2024

Conversation

AurelienFT
Copy link
Contributor

Fix #869

Alternative studied :

  • derive_more most maintained but doesn't features we need such as PartialEq (Derive PartialEq? JelteF/derive_more#414) might be a good fit in the future.
  • derive-where same issue and even less maintained.

Educe is nearly a drop-in replacement, one of the maintainer is still pretty active.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • If performance characteristic of an instruction change, update gas costs as well or make a follow-up PR for that
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@AurelienFT AurelienFT added the no changelog Skips the CI changelog check label Dec 3, 2024
@AurelienFT AurelienFT requested a review from a team December 3, 2024 15:11
@AurelienFT AurelienFT requested a review from a team December 6, 2024 00:57
@AurelienFT AurelienFT added this pull request to the merge queue Dec 6, 2024
Merged via the queue into master with commit 319c43a Dec 6, 2024
40 checks passed
@AurelienFT AurelienFT deleted the remove_derivative branch December 6, 2024 09:35
@AurelienFT AurelienFT mentioned this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Skips the CI changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2024-0388: derivative is unmaintained; consider using an alternative
3 participants