-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Can you remove the inline styles, move them to the styles cost we have always creating a new item for it. Ex from
style={{ a: 1 }} to style={styles.myA}
- You could also split more the code, and improve the use of state, but we can do this later.
packages/app/src/systems/Ecosystem/components/FeaturedProjects/FeaturedProjects.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
social buttons are grabbing too much attention, maybe try to do only bordered instead of background?
or keep same color? specially the X one when it's alone, that red button is the first thing you look
yes @Rubyt0x much better now, I will fix audit in other PR then you can get rid of CI error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other changes requested from product side will come, so I'm blocking it for now
New features:
Add Project
buttonDesign enhancements:
Fixes #197