Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: test compute_call_instructions_len #1129

Closed
iqdecay opened this issue Sep 11, 2023 · 0 comments · Fixed by #1183
Closed

test: test compute_call_instructions_len #1129

iqdecay opened this issue Sep 11, 2023 · 0 comments · Fixed by #1183
Assignees
@Br1ght0ne

Comments

@iqdecay
Copy link
Contributor

iqdecay commented Sep 11, 2023

This function is currently untested, even though the slightest modification of it can lead to the ContractNotFound issue.
@iqdecay iqdecay self-assigned this Sep 11, 2023
@digorithm digorithm assigned Br1ght0ne and unassigned iqdecay Oct 30, 2023
@Br1ght0ne Br1ght0ne mentioned this issue Nov 1, 2023
Merged
6 tasks
Br1ght0ne added a commit that referenced this issue Dec 15, 2023
@Br1ght0ne @MujkicA
@iqdecay @hal3e @segfault-magnet
chore: add test for compute_calls_instructions_len (#1183)
f74e9bb 
Close #1129.

I added a test case for an empty (random) contract, would like some
feedback on what kinds of non-empty contracts to test.

### Checklist
- [x] I have linked to any relevant issues.
- [x] I have updated the documentation.
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added necessary labels.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.

---------

Co-authored-by: MujkicA <32431923+MujkicA@users.noreply.github.com>
Co-authored-by: iqdecay <victor@berasconsulting.com>
Co-authored-by: hal3e <git@hal3e.io>
Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Br1ght0ne Br1ght0ne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add test for compute_calls_instructions_len FuelLabs/fuels-rs
2 participants
@Br1ght0ne @iqdecay