feat!: represent small values as single bytes #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
digorithm
added
P1
xunilrj
force-pushed
the
IGI-111/int-mem-repr
branch
2 times, most recently
from
d5d240a
to
d2a1b11
Compare
7 tasks
IGI-111
pushed a commit
to FuelLabs/sway
that referenced
this pull request
Nov 2, 2023
## Description This PR is needed to make FuelLabs/fuels-rs#1163 green. We can configure the sway branch for the CI, but not the stdlib. With this, we will be able to edit github CI config and point to whichever sway version we want. ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
xunilrj
force-pushed
the
IGI-111/int-mem-repr
branch
from
e65a982
to
c021498
Compare
xunilrj
requested review from
digorithm,
iqdecay,
hal3e,
MujkicA,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
Voxelot
reviewed
Nov 10, 2023
digorithm
reviewed
Nov 10, 2023
Br1ght0ne
reviewed
Nov 10, 2023
Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
segfault-magnet
previously approved these changes
Nov 10, 2023
hal3e
changed the title
hal3e
previously approved these changes
Nov 10, 2023
digorithm
previously approved these changes
Nov 10, 2023
xunilrj
dismissed stale reviews from digorithm, hal3e, and segfault-magnet
via
5880140
Salka1988
approved these changes
Nov 10, 2023
digorithm
approved these changes
Nov 10, 2023
MujkicA
approved these changes
Nov 10, 2023
xunilrj
added a commit
to FuelLabs/sway
that referenced
this pull request
Nov 17, 2023
## Description This PR contains some necessary fixes to enable this FuelLabs/fuels-rs#1163 to be merged. 1 - It guarantees that when the env var `FORC_IMPLICIT_STD_GIT_BRANCH` is used, no `tag` or `rev` is also used; 2 - It removes all warnings from the sway std-lib; 3 - It fixes reading predicates witness when it is only one byte. ## Checklist - [ ] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers. --------- Co-authored-by: hal3e <git@hal3e.io> Co-authored-by: IGI-111 <igi-111@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just the first of a series that will update the encoding/decoding of Sway types.
At this PR we are updating codec to Sway 0.48 (in the future for now) and how it treats u8 and bool. Now they are encoded (when possible) with just one byte;
It also fixes a limitation of enums tags being u8 (this was a bug);
The test
test_heap_type_in_enumshad to be commented because we are changing our heap types are encoded, and at the moment, they are not working. :(Changes to
.github/workflows/ci.ymlcan be ignore for now and will be removed after FuelLabs/sway#5264 is merged. As the commented tests.Checklist