Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add from_hex_str for Bytes #1205

Merged
merged 2 commits into from
Nov 17, 2023
Merged

feat: add from_hex_str for Bytes #1205

merged 2 commits into from
Nov 17, 2023

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Nov 16, 2023 •
edited
Loading

close: #1204

co-developed with: @segfault-magnet

Adds Bytes::from_hex_str(hex: &str). Adds test and updates documentation.

Checklist

  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@hal3e hal3e added the enhancement New feature or request label Nov 16, 2023
Br1ght0ne
Br1ght0ne approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@Br1ght0ne Br1ght0ne left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a small nit, but it may be ignored if it's not too obvious for the reader.

packages/fuels-core/src/types/core/bytes.rs Show resolved Hide resolved
@segfault-magnet segfault-magnet merged commit 5793398 into master Nov 17, 2023
@segfault-magnet segfault-magnet deleted the feat/add-bytes-from-hex-str branch November 17, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segfault-magnet segfault-magnet segfault-magnet approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@iqdecay iqdecay iqdecay approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@MujkicA MujkicA Awaiting requested review from MujkicA MujkicA is a code owner

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

Assignees

@hal3e hal3e

@segfault-magnet segfault-magnet

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write some docs for the Bytes support
4 participants
@hal3e @Br1ght0ne @iqdecay @segfault-magnet