-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add support for experimental encoding in logs #1259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hal3e
requested review from
digorithm,
iqdecay,
MujkicA,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
January 23, 2024 16:14
hal3e
changed the title
feat: add support
feat!: add support for experimental encoding in logs
Jan 23, 2024
MujkicA
reviewed
Jan 25, 2024
MujkicA
reviewed
Jan 25, 2024
packages/fuels-core/src/codec/abi_decoder/experimental_bounded_decoder.rs
Outdated
Show resolved
Hide resolved
MujkicA
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
digorithm
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work -- excited to see this new ABI decoding in action 😍
Left a minor question but it shouldn't be a blocker.
22 tasks
MujkicA
approved these changes
Jan 29, 2024
Br1ght0ne
approved these changes
Jan 29, 2024
Closed
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1247, #1151, #901, #898
This PR adds support for sway's experimental encoding in logs. The new encoder is enabled with the
experimental
rustflag.To run the tests, first build the forc projects with:
forc build --path packages/fuels --experimental-new-encoding
then run the tests with:RUSTFLAGS='--cfg experimental' cargo test --test logs
What was done:
ExperimentalBoundedDecoder
RawSlice
was encoded and decodedexperimental
flagBREAKING CHANGE:
RawSlice
encoding and decodingChecklist