Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use blob_exists endpoint before uploading contract blob #1573

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Jan 15, 2025

Summary

While working on the total_fee and total_gas PR I noticed that we rely on the error message to check if a blob is already included. Refactored the code to use the blob_exist endpoint.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@hal3e hal3e added the tech-debt Improves code quality or safety label Jan 15, 2025
@hal3e hal3e self-assigned this Jan 15, 2025
@hal3e hal3e merged commit 7432468 into master Jan 17, 2025
45 checks passed
@hal3e hal3e deleted the hal3e/check-if-blob-already-uploaded branch January 17, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Improves code quality or safety
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants