Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve calculate_required_asset_amounts for contract calls #1576

Merged
merged 6 commits into from
Jan 17, 2025
Merged

refactor: improve calculate_required_asset_amounts for contract calls #1576

merged 6 commits into from
Jan 17, 2025

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Jan 15, 2025

Summary

Improve the calculation by removing repetitive steps and unnecessary collects.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@hal3e hal3e added the tech-debt Improves code quality or safety label Jan 15, 2025
@hal3e hal3e self-assigned this Jan 15, 2025
@hal3e hal3e merged commit 1c6c231 into master Jan 17, 2025
45 checks passed
@hal3e hal3e deleted the hal3e/calculate-required-asset-amount-improvoment branch January 17, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MujkicA MujkicA MujkicA approved these changes

@digorithm digorithm digorithm approved these changes

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet is a code owner

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

Assignees

@hal3e hal3e

Labels
tech-debt Improves code quality or safety
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hal3e @digorithm @MujkicA