-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contracts): add tx_id to FuelCallResponse #734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Short and neat. gg!
Just gotta fix the tests, but after that feel free to merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing my review until the test gets fixed to prevent an accidental merge haha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question regarding async.
ddf32b3
to
dd13efe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I like that we don't need to call the network to get the tx_id
, but I do agree with the comment about changing the get_response
API.
First of all this is afaiu a breaking change that we should consider carefully.
Second, I agree with you that it is wonky.
I'd like to see what a caching solution looks like 😄
Can't we include an extra Receipts
type that just gives us the txid? But it would feel bad to "lie" about it being a tx receipt.
EDIT: @digorithm can you weigh in on priority vs (having an async
|| changing the API)?
Hmm, seems like we're bound to modify the API, regardless of the options. Having to append Are we deciding between If so, the first option doesn't require the user to know more internal details and manually fetch the tx id, which I believe to be better than the second option. |
Agreed but I feel like Br1ght0ne is hinting that he maybe has a solution that isn't async and doesn't need the user to know the tx_id. |
8cdac16
d4d6731
to
00e2ada
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please add documentation and tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Co-authored-by: iqdecay <victor@berasconsulting.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Description of changes
Close #733.
tx_id
isTransaction::Script.id()
tx_id
isExecutableFuelCall.tx.id()
Checklist