Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support Bytes type return from contract #868

Merged
merged 27 commits into from
Mar 20, 2023
Merged

feat: support Bytes type return from contract #868

merged 27 commits into from
Mar 20, 2023

Conversation

iqdecay
Copy link
Contributor

@iqdecay iqdecay commented Mar 2, 2023 •
edited
Loading

This PR closes #723.
EDIT: needs #883 to go in first.

@iqdecay iqdecay requested a review from digorithm as a code owner March 2, 2023 03:14
@iqdecay iqdecay marked this pull request as draft March 2, 2023 03:14
@iqdecay iqdecay force-pushed the iqdecay/feat-bytes-return branch from f05a7af to 23cf3ca Compare March 6, 2023 23:04
@iqdecay iqdecay marked this pull request as ready for review March 6, 2023 23:30
@iqdecay iqdecay requested a review from a team March 6, 2023 23:31
@iqdecay iqdecay force-pushed the iqdecay/feat-bytes-return branch from 23cf3ca to 3ff64bf Compare March 7, 2023 09:27
@iqdecay iqdecay mentioned this pull request Mar 7, 2023
Merged
segfault-magnet
segfault-magnet reviewed Mar 7, 2023
View reviewed changes
packages/fuels-code-gen/src/program_bindings/resolved_type.rs Outdated Show resolved Hide resolved
packages/fuels-core/src/abi_decoder.rs Outdated Show resolved Hide resolved
packages/fuels-core/src/abi_decoder.rs Outdated Show resolved Hide resolved
packages/fuels-core/src/abi_encoder.rs Show resolved Hide resolved
packages/fuels-core/src/abi_encoder.rs Show resolved Hide resolved
packages/fuels-programs/src/call_utils.rs Outdated Show resolved Hide resolved
packages/fuels-programs/src/call_utils.rs Outdated Show resolved Hide resolved
packages/fuels-types/src/param_types.rs Outdated Show resolved Hide resolved
@iqdecay iqdecay force-pushed the iqdecay/feat-bytes-return branch 2 times, most recently from f7461a6 to d026389 Compare March 10, 2023 21:12
@iqdecay iqdecay requested a review from a team March 10, 2023 21:13
@iqdecay iqdecay force-pushed the iqdecay/feat-bytes-return branch from d026389 to 11a2430 Compare March 13, 2023 13:35
@iqdecay iqdecay marked this pull request as draft March 13, 2023 13:36
Base automatically changed from iqdecay/feat-contract-vec-return to master March 13, 2023 14:18
@iqdecay iqdecay force-pushed the iqdecay/feat-bytes-return branch from 11a2430 to 32aef27 Compare March 13, 2023 15:04
@iqdecay iqdecay marked this pull request as ready for review March 13, 2023 17:00
@iqdecay iqdecay force-pushed the iqdecay/feat-bytes-return branch from 62d4d5e to 49d6fc3 Compare March 13, 2023 18:11
MujkicA
MujkicA reviewed Mar 14, 2023
View reviewed changes
Copy link
Contributor

@MujkicA MujkicA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

packages/fuels-test-helpers/src/signers.rs Outdated Show resolved Hide resolved
Salka1988
Salka1988 previously approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@Salka1988 Salka1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

segfault-magnet
segfault-magnet reviewed Mar 14, 2023
View reviewed changes
packages/fuels-code-gen/src/program_bindings/utils.rs Outdated Show resolved Hide resolved
packages/fuels-core/src/abi_decoder.rs Outdated Show resolved Hide resolved
packages/fuels-core/src/abi_decoder.rs Outdated Show resolved Hide resolved
packages/fuels-programs/src/call_utils.rs Outdated Show resolved Hide resolved
packages/fuels-types/src/param_types.rs Outdated Show resolved Hide resolved
packages/fuels-types/src/param_types.rs Outdated Show resolved Hide resolved
packages/fuels-types/src/param_types.rs Outdated Show resolved Hide resolved
packages/fuels-types/src/param_types.rs Outdated Show resolved Hide resolved
packages/fuels-types/src/param_types.rs Outdated Show resolved Hide resolved
packages/fuels-types/src/param_types.rs Outdated Show resolved Hide resolved
@segfault-magnet
Copy link
Contributor

segfault-magnet commented Mar 14, 2023 •
edited
Loading

Reviewed alongside @hal3e .

@digorithm digorithm added the enhancement New feature or request label Mar 14, 2023
@iqdecay @segfault-magnet
refactor: apply suggestions from code review
3e440dd 
Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
@iqdecay iqdecay enabled auto-merge (squash) March 15, 2023 13:14
@iqdecay iqdecay requested a review from a team March 17, 2023 12:00
hal3e
hal3e approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@iqdecay iqdecay merged commit c75ef06 into master Mar 20, 2023
@iqdecay iqdecay deleted the iqdecay/feat-bytes-return branch March 20, 2023 21:30
hal3e pushed a commit that referenced this pull request Mar 21, 2023
@iqdecay @MujkicA
@segfault-magnet @hal3e
feat: support Bytes type return from contract (#868)
5fd0964 
This PR closes #723 by enabling the `Bytes` type to be returned from contracts.

Co-authored-by: Ahmed Mujkic <32431923+MujkicA@users.noreply.github.com>
Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
This was referenced Mar 22, 2023
Closed
Closed
@iqdecay iqdecay mentioned this pull request Apr 18, 2023
Closed
@camsjams camsjams mentioned this pull request May 16, 2023
Closed
@camsjams camsjams mentioned this pull request Aug 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hal3e hal3e hal3e approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@MujkicA MujkicA Awaiting requested review from MujkicA MujkicA is a code owner

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet is a code owner

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

Assignees

@iqdecay iqdecay

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for the new stdlib type Bytes
6 participants
@iqdecay @segfault-magnet @Salka1988 @MujkicA @hal3e @digorithm