Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gas estimation to script calls #973

Merged
merged 3 commits into from
May 19, 2023
Merged

feat: add gas estimation to script calls #973

merged 3 commits into from
May 19, 2023

Conversation

MujkicA
Copy link
Contributor

@MujkicA MujkicA commented May 17, 2023

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@MujkicA MujkicA requested review from digorithm and iqdecay as code owners May 17, 2023 21:55
@digorithm digorithm added the enhancement New feature or request label May 17, 2023
@digorithm digorithm requested a review from a team May 17, 2023 23:06
digorithm
digorithm approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; short and sweet!

@calldelegation calldelegation mentioned this pull request May 18, 2023
Open
Salka1988
Salka1988 approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@Salka1988 Salka1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

iqdecay
iqdecay approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@MujkicA MujkicA merged commit 301edda into master May 19, 2023
@MujkicA MujkicA deleted the mujkica/estimation-helper-for-script-calls branch May 19, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hal3e hal3e hal3e approved these changes

@iqdecay iqdecay iqdecay approved these changes

@Salka1988 Salka1988 Salka1988 approved these changes

@digorithm digorithm digorithm approved these changes

Assignees

@MujkicA MujkicA

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MujkicA @digorithm @Salka1988 @iqdecay @hal3e