Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade fuel-core and fuel-vm crates versions #997

Merged
merged 38 commits into from
Jul 17, 2023
Merged

deps: upgrade fuel-core and fuel-vm crates versions #997

merged 38 commits into from
Jul 17, 2023

Conversation

iqdecay
Copy link
Contributor

@iqdecay iqdecay commented Jun 11, 2023 •
edited
Loading

This PR is here to adapt the SDK to :

  • fuel-core@0.19
  • fuel-vm@0.34

@iqdecay iqdecay force-pushed the iqdecay/deps-fuel-core-update branch from b4f55c2 to 3b2c54a Compare June 14, 2023 12:14
@iqdecay iqdecay changed the title deps: fuel-core anticipated upgrade deps: upgrade fuel-core and fuel-vm crates versions Jun 14, 2023
@iqdecay
Copy link
Contributor Author

iqdecay commented Jun 15, 2023

Still some work to be done wrt to Metadata.

@iqdecay iqdecay marked this pull request as draft June 15, 2023 16:44
@iqdecay iqdecay force-pushed the iqdecay/deps-fuel-core-update branch 2 times, most recently from a697340 to 918d71d Compare June 20, 2023 14:48
@iqdecay iqdecay force-pushed the iqdecay/deps-fuel-core-update branch from 918d71d to ea17820 Compare June 21, 2023 13:53
@iqdecay iqdecay marked this pull request as ready for review June 22, 2023 08:35
@iqdecay iqdecay requested a review from segfault-magnet July 10, 2023 14:42
@Dentosal
Copy link
Member

I fixed all remaining cases. Reviewers, please pay extra attention to gas changes in b8086aa, I'm unsure whether they are correct.

@iqdecay iqdecay mentioned this pull request Jul 11, 2023
Merged
3 tasks
@iqdecay
Copy link
Contributor Author

iqdecay commented Jul 11, 2023

ty I didn't notice I had wrong gas values!

@iqdecay iqdecay mentioned this pull request Jul 11, 2023
Merged
@iqdecay iqdecay requested a review from segfault-magnet July 12, 2023 08:19
segfault-magnet
segfault-magnet reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@segfault-magnet segfault-magnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for the reexports to be added to fuels before approving.

@Dentosal Dentosal requested a review from segfault-magnet July 13, 2023 10:21
@Dentosal Dentosal merged commit 6c7e7a0 into master Jul 17, 2023
@Dentosal Dentosal deleted the iqdecay/deps-fuel-core-update branch July 17, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segfault-magnet segfault-magnet segfault-magnet approved these changes

@hal3e hal3e hal3e approved these changes

@Salka1988 Salka1988 Salka1988 approved these changes

@Dentosal Dentosal Dentosal approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@MujkicA MujkicA Awaiting requested review from MujkicA MujkicA is a code owner

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

@xgreenx xgreenx Awaiting requested review from xgreenx

Assignees

@iqdecay iqdecay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iqdecay @Dentosal @xgreenx @Salka1988 @hal3e @segfault-magnet