Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade graphql-request library to latest version #2567

Closed
arboleya opened this issue Jun 20, 2024 · 2 comments · Fixed by #3442
Closed

Upgrade graphql-request library to latest version #2567

arboleya opened this issue Jun 20, 2024 · 2 comments · Fixed by #3442
Assignees
@danielbate
Labels
chore Issue is a chore

Comments

@arboleya
Copy link
Member

arboleya commented Jun 20, 2024 •
edited by petertonysmith94
Loading

We should consider upgrading graphql-request from 5.0.0 to 7.1.0.

Due to breaking changes, this couldn't be done automatically by dependabot:
@arboleya arboleya added chore Issue is a chore p2 labels Jun 20, 2024
@arboleya arboleya added this to the 0.x mainnet milestone Jun 20, 2024
@arboleya arboleya changed the title Upgrade graphql-request Upgrade graphql-request library to latest version Jun 20, 2024
@arboleya arboleya mentioned this issue Jun 20, 2024
Closed
@arboleya arboleya modified the milestones: 0.x mainnet, 0.x post-launch Jun 24, 2024
@petertonysmith94 petertonysmith94 mentioned this issue Jul 8, 2024
Closed
@arboleya arboleya removed this from the 0.x post-launch milestone Jul 19, 2024
@arboleya arboleya removed the p2 label Jul 20, 2024
@arboleya arboleya added the temp:notion label Sep 8, 2024 — with Linear
@arboleya arboleya added the temp-linear label Sep 8, 2024 — with Linear
@nedsalk Linear
Copy link
Contributor

nedsalk commented Sep 27, 2024

#1597 is a related alternative which, at the time, was closed due to lack of a majority in favor of it. A revisit of it might be worthy.

@petertonysmith94 petertonysmith94 mentioned this issue Oct 2, 2024
Closed
@danielbate danielbate self-assigned this Dec 3, 2024
@danielbate
Copy link
Member

I've managed to upgrade 1 major version, however v7 is ESM only meaning we'll need changes to our build tooling to support it... This could be strong case for #1597 or maybe build tooling adjustments, I'll probably have a think and open a discussion.

@danielbate danielbate mentioned this issue Dec 3, 2024
Merged
4 tasks
This was referenced Dec 3, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielbate danielbate

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: upgrade graphql-request@6.1.0 FuelLabs/fuels-ts
3 participants
@arboleya @danielbate @nedsalk