Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade graphql-request@6.1.0 #3442

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented Dec 3, 2024

Summary

Upgrades a major version of graphql-request. It is actually currently at v7 with v8 coming very soon. I have discussed why we can't upgrade that high here.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@danielbate danielbate added the chore Issue is a chore label Dec 3, 2024
@danielbate danielbate self-assigned this Dec 3, 2024
Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 11:29am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 11:29am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 11:29am

Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one. Since we can't upgrade further now, this PR is enough to close #2567.

packages/account/src/providers/provider.ts Show resolved Hide resolved
Copy link

codspeed-hq bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #3442 will improve performances by 10.02%

Comparing db/chore/upgrade-gql-request (c5bfbab) with master (4131e74)

Summary

⚡ 1 improvements
✅ 17 untouched benchmarks

Benchmarks breakdown

Benchmark master db/chore/upgrade-gql-request Change
should successfully get transaction cost estimate for a single contract call (x20 times) 27.5 ms 25 ms +10.02%

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Coverage Report:

Lines Branches Functions Statements
76.42%(+0%) 69.94%(-0.02%) 74.46%(+0%) 76.45%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 69.02%
(+0%)
57.14%
(-0.07%)
70.96%
(+0%)
68.73%
(+0%)

@danielbate danielbate merged commit 260274a into master Dec 3, 2024
58 of 61 checks passed
@danielbate danielbate deleted the db/chore/upgrade-gql-request branch December 3, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade graphql-request library to latest version
4 participants