Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: docs snippets utility functions #1011

Merged
merged 50 commits into from
Jul 24, 2023
Merged

refactor: docs snippets utility functions #1011

merged 50 commits into from
Jul 24, 2023

Conversation

danielbate
Copy link
Member

@danielbate danielbate commented May 22, 2023 •
edited
Loading

  • Introduction of createAndDeployContractFromProject to reduce code duplication in tests
  • Renaming of helixfied -> hexlified

danielbate and others added 30 commits May 10, 2023 17:13
feat: create evm address interface
0cd936f
feat: create evm address clas
78ee89a
feat: unit tests for evm address wrapper class
ea28ccf
chore: linting
3d1f8d7
chore: linting
c334661
feat: support from public key in evm address
19c98a0
Merge branch 'master' of https://github.com/FuelLabs/fuels-ts into db…
7c89e41 
…/feat/support-evm-address
feat: remove evm address class and unit tests
0126ad1
feat: create types for B256 Evm and Evm address
ed1e49a
feat: create address utility function to convert a b256 to an evm b256
54cf47c
feat: add address function to return as evm addres
4898bcd
feat: add unit tests for address to evm address and utility function
0a4ae8f
feat: create snippets util function generate test wallet and deploy a…
48ace55 
… contract
test: create docs snippets tests for evm address
46b579a
chore: remove redundant gitignore from evm address doc snippet contract
8d0fc2e
test: rename evm address docs snippet test
3694a16
docs: create documentation for evm address
252def3
docs: modify docs snippets for evm address
888a327
docs: add evm address to docs config
b4c084a
test: alter evm address test asserttions
c306beb
docs: update evm address title capitalisation
6d3a44a
feat: add evm address type to typegen
cb11146
test: add unit test for evm address type with forc project
4e5241b
test: add evm address to full typegen test suit
e81ce63
feat: add ignore evm struct to struct typegen
c6b1a34
feat: add evm address type to supported types in typegen
b26ac5f
chore: changeset
7294d62
feat: add forc projects to workspace
8d54ca7
@danielbate
Merge branch 'master' into db/feat/support-evm-address
560d1a0
test: add address import to dts test
ff57b37
Torres-ssf
Torres-ssf previously approved these changes May 29, 2023
View reviewed changes
@danielbate danielbate enabled auto-merge (squash) May 29, 2023 13:17
arboleya
arboleya reviewed May 29, 2023
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we extract createAndDeployContractFromProject() into its own file? Other tests would benefit from having it shared.

I'd suggest adding it here:

  • packages/utils/src/test-utils/deployForcProject.ts

@danielbate danielbate disabled auto-merge May 29, 2023 15:15
danielbate and others added 8 commits May 30, 2023 09:38
@danielbate
Merge branch 'master' into db/refactor/docs-snippets-utility-functions
8dfa755
@danielbate
Merge branch 'master' into db/refactor/docs-snippets-utility-functions
091f69c
Merge branch 'master' of https://github.com/FuelLabs/fuels-ts into db…
77213b1 
…/refactor/docs-snippets-utility-functions
@danielbate
Merge branch 'master' into db/refactor/docs-snippets-utility-functions
a5a0d0e
Merge branch 'master' of https://github.com/FuelLabs/fuels-ts into db…
8f8054d 
…/refactor/docs-snippets-utility-functions
Merge branch 'master' of https://github.com/FuelLabs/fuels-ts into db…
57f016d 
…/refactor/docs-snippets-utility-functions
test: implement deploy project test across more docs tests
a0a29e1
Merge branch 'db/refactor/docs-snippets-utility-functions' of https:/…
01d0fac 
…/github.com/FuelLabs/fuels-ts into db/refactor/docs-snippets-utility-functions
@arboleya arboleya requested review from Torres-ssf and arboleya July 23, 2023 09:35
@danielbate
Copy link
Member Author

Could we extract createAndDeployContractFromProject() into its own file? Other tests would benefit from having it shared.

I'd suggest adding it here:

  • packages/utils/src/test-utils/deployForcProject.ts

So this couldn't be extracted because of cyclic dependency issues, unless we do want a fuels dep in utils. I think utils should remain as fuels agnostic and purely functional helpers. Then fuel-gauge and docs-snippets can have their own helpers.

@danielbate danielbate marked this pull request as draft July 24, 2023 11:10
@danielbate danielbate marked this pull request as ready for review July 24, 2023 11:11
@danielbate danielbate enabled auto-merge (squash) July 24, 2023 11:12
Dhaiwat10
Dhaiwat10 approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@Dhaiwat10 Dhaiwat10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@danielbate danielbate merged commit 39479c2 into master Jul 24, 2023
@danielbate danielbate deleted the db/refactor/docs-snippets-utility-functions branch July 24, 2023 11:27
nedsalk pushed a commit that referenced this pull request Jul 25, 2023
@danielbate @arboleya @nedsalk
refactor: docs snippets utility functions (#1011)
7a58ac3 
* feat: create evm address interface

* feat: create evm address clas

* feat: unit tests for evm address wrapper class

* chore: linting

* chore: linting

* feat: support from public key in evm address

* feat: remove evm address class and unit tests

* feat: create types for B256 Evm and Evm address

* feat: create address utility function to convert a b256 to an evm b256

* feat: add address function to return as evm addres

* feat: add unit tests for address to evm address and utility function

* feat: create snippets util function generate test wallet and deploy a contract

* test: create docs snippets tests for evm address

* chore: remove redundant gitignore from evm address doc snippet contract

* test: rename evm address docs snippet test

* docs: create documentation for evm address

* docs: modify docs snippets for evm address

* docs: add evm address to docs config

* test: alter evm address test asserttions

* docs: update evm address title capitalisation

* feat: add evm address type to typegen

* test: add unit test for evm address type with forc project

* test: add evm address to full typegen test suit

* feat: add ignore evm struct to struct typegen

* feat: add evm address type to supported types in typegen

* chore: changeset

* feat: add forc projects to workspace

* test: add address import to dts test

* refactor: rename helixfied to hexlified

* refactor: use deploy contract test util in types docs snippets test

* chore: changeset

* chore: delete redundant gitignore

* feat: remove address from evm dts

* refactor: clean up remain helix references

* refactor: fix hexlified casing

* chore: force rebuild

* chore: force rebuild

* test: implement deploy project test across more docs tests

* chore: adjusting residual tyops after merging with master

---------

Co-authored-by: danielbate <--global>
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@camsjams camsjams Awaiting requested review from camsjams

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

Assignees

@danielbate danielbate

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielbate @arboleya @Torres-ssf @Dhaiwat10