-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: increase supported predicate length in transactions #1033
Merged
danielbate
merged 8 commits into
master
from
db/feat/increase-supported-predicate-length-in-transactions
May 31, 2023
Merged
feat: increase supported predicate length in transactions #1033
danielbate
merged 8 commits into
master
from
db/feat/increase-supported-predicate-length-in-transactions
May 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success974 tests passing in 172 suites. Report generated by 🧪jest coverage report action from 1c4fbdf |
…h-in-transactions
danielbate
requested review from
digorithm,
arboleya,
camsjams,
Torres-ssf,
Dhaiwat10 and
nedsalk
as code owners
May 31, 2023 14:21
This reverts commit 04cf5a6.
…ions' of https://github.com/FuelLabs/fuels-ts into db/feat/increase-supported-predicate-length-in-transactions
Torres-ssf
approved these changes
May 31, 2023
arboleya
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯
camsjams
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
…h-in-transactions
danielbate
deleted the
db/feat/increase-supported-predicate-length-in-transactions
branch
May 31, 2023 16:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the TS SDK, we are expecting a u16 integer for predicateLength:
fuels-ts/packages/transactions/src/coders/input.ts
Lines 72 to 73 in 0b3c342
Therefore encoding/decoding larger predicates will throw an error. We can actually expect a u32 integer for predicate length, as dictated by the fuel spec.
This PR will support u32 int length predicates and support with tests.