Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for Bytes and RawSlice as inputs and outputs for Contracts #1221

Merged
merged 30 commits into from
Sep 25, 2023
Merged

feat: add support for Bytes and RawSlice as inputs and outputs for Contracts #1221

merged 30 commits into from
Sep 25, 2023

Conversation

camsjams
Copy link
Contributor

@camsjams camsjams commented Aug 31, 2023 •
edited
Loading

closes #1188

Bytes

vector of u8 data

Raw Slice

vector of u64 data

@camsjams camsjams self-assigned this Aug 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
84.52% (+0.11% 🔼)
 5139/6080
🟡 Branches
66.02% (+0.06% 🔼)
 752/1139
🟡 Functions
73.86% (+0.16% 🔼)
 845/1144
🟢 Lines
84.58% (+0.12% 🔼)
 4913/5809
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / byte.ts
 96.55% 50% 100% 96.55%
🟢
... / raw-slice.ts
 95.24% 0% 100% 95.24%
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🔴
... / utils.ts
40% (-6.15% 🔻)
 0% 0%
35.71% (-5.95% 🔻)

Test suite run success

1221 tests passing in 213 suites.

Report generated by 🧪jest coverage report action from 9ba3bde

nedsalk
nedsalk previously approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@nedsalk nedsalk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Although you've got a failing test, so another review round will be needed. But I don't see any issue with the code as it is.

@camsjams camsjams requested a review from nedsalk September 21, 2023 05:21
@camsjams
Copy link
Contributor Author

LGTM! Although you've got a failing test, so another review round will be needed. But I don't see any issue with the code as it is.

Ok - I've fixed this build error

This was referenced Sep 21, 2023
Merged
Merged
@nedsalk nedsalk self-requested a review September 21, 2023 11:24
nedsalk
nedsalk previously approved these changes Sep 21, 2023
View reviewed changes
@nedsalk nedsalk self-requested a review September 22, 2023 06:24
nedsalk
nedsalk previously approved these changes Sep 22, 2023
View reviewed changes
@camsjams camsjams enabled auto-merge (squash) September 23, 2023 15:48
@nedsalk nedsalk self-requested a review September 25, 2023 05:14
Dhaiwat10
Dhaiwat10 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@Dhaiwat10 Dhaiwat10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪄

@camsjams camsjams merged commit 68390ac into master Sep 25, 2023
7 checks passed
@camsjams camsjams deleted the cm/issue-1188-bytes branch September 25, 2023 15:35
@github-actions github-actions bot mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@nedsalk nedsalk nedsalk approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

Assignees

@camsjams camsjams

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for the new stdlib type Bytes and RawSlice for inputs and outputs for Contracts
3 participants
@camsjams @nedsalk @Dhaiwat10