Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for StdString for Contracts, Scripts, and Predicates #1277

Merged
merged 86 commits into from
Oct 3, 2023

Conversation

camsjams
Copy link
Contributor

@camsjams camsjams commented Sep 21, 2023

Closes #1276

Adds StdString support:

Base automatically changed from cm/issue-1274 to master September 27, 2023 16:30
@camsjams camsjams marked this pull request as ready for review September 27, 2023 16:31
Copy link
Member

@Dhaiwat10 Dhaiwat10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think you might need to rename two tests though:

packages/fuel-gauge/src/std-lib-string.test.ts Outdated Show resolved Hide resolved
packages/fuel-gauge/src/std-lib-string.test.ts Outdated Show resolved Hide resolved
Cameron Manavian and others added 2 commits September 30, 2023 16:24
Co-authored-by: Dhaiwat <dhaiwatpandya@gmail.com>
Co-authored-by: Dhaiwat <dhaiwatpandya@gmail.com>
@camsjams
Copy link
Contributor Author

@Dhaiwat10 good catch! Yea moving fast didn't notice

Dhaiwat10
Dhaiwat10 previously approved these changes Oct 2, 2023
@camsjams camsjams enabled auto-merge (squash) October 3, 2023 04:49
@camsjams
Copy link
Contributor Author

camsjams commented Oct 3, 2023

@nedsalk / @Dhaiwat10 / @danielbate I've made the requested updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support dynamic String type for Contracts, Scripts, and Predicates
5 participants