-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename Provider method switchUrl
to connect
#1294
refactor: rename Provider method switchUrl
to connect
#1294
Conversation
Coverage report
Show files with reduced coverage 🔻
Test suite run success1237 tests passing in 213 suites. Report generated by 🧪jest coverage report action from 4cae557 |
@LuizAsFight @luizstacio FWIW, I was the one who suggested renaming the The reasoning against the I have zero attachment to this, so feel free to do as you please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this as-is, because I know it's been an external request.
However, I left my reasoning behind some points that [I believe] could be improved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes based on this discussion. Other than that, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know it changed, no opinion on the name itself. But yea it might have broken developer code.
LGTM
This PR:
switchUrl
toconnect
.chain
andnode
data is always fetched when instantiating a new Provider or when updating the Provider url (connect