Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make transactionRequest protected on BaseInvocationScope #1296

Conversation

Torres-ssf
Copy link
Contributor

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 84.83% 5168/6092
🟡 Branches 66.29% 759/1145
🟡 Functions 75.09% 850/1132
🟢 Lines 84.71% 4949/5842

Test suite run success

1232 tests passing in 213 suites.

Report generated by 🧪jest coverage report action from 182e9ff

arboleya
arboleya previously approved these changes Sep 26, 2023
digorithm
digorithm previously approved these changes Sep 26, 2023
camsjams
camsjams previously approved these changes Sep 27, 2023
Copy link
Contributor

@camsjams camsjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small notes

@Torres-ssf Torres-ssf merged commit 79e0d3b into master Sep 27, 2023
@Torres-ssf Torres-ssf deleted the st/refactor/make-transaction-request-protected-on-base-invocation-scope branch September 27, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contract scope transactionRequest prop not updated
4 participants