-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve fromEvmAddress
developer experience
#1309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbate
requested review from
digorithm,
arboleya,
camsjams,
Torres-ssf,
Dhaiwat10 and
nedsalk
as code owners
October 3, 2023 05:41
Coverage report
Show files with reduced coverage 🔻
Test suite run success1261 tests passing in 216 suites. Report generated by 🧪jest coverage report action from 6820f79 |
Braqzen
reviewed
Oct 3, 2023
camsjams
previously approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just nitpick on the function rename
…/feat/improve-from-evm-address-dev-ex
Dhaiwat10
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪄
Braqzen
approved these changes
Oct 5, 2023
camsjams
approved these changes
Oct 5, 2023
Torres-ssf
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current implementation of the
fromEvmAddress
method expects a wrapped and padded Evm Address to return anAddress
. As the EVM returns address unpadded, users would have to pad then wrap it to be compatible with the Sway/TS type.To improve this experience, the
fromEvmAddress
method now accepts and unwrapped/unpadded string and will validate it to instantiate anAddress
. ThetoEvmAddress
method has been renamedtoWrappedEvmAddress
to adhere to the above change.Closes #1262