Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: purge the usage of the hardcoded constant VM_TX_MEMORY #1318

Merged
merged 1 commit into from
Oct 5, 2023
Merged

refactor: purge the usage of the hardcoded constant VM_TX_MEMORY #1318

merged 1 commit into from
Oct 5, 2023

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Oct 5, 2023 •
edited
Loading

Closes #1313
Closes #825

@Dhaiwat10 Dhaiwat10 requested a review from digorithm as a code owner October 5, 2023 12:54
@Dhaiwat10 Dhaiwat10 self-assigned this Oct 5, 2023
@Dhaiwat10 Dhaiwat10 enabled auto-merge (squash) October 5, 2023 12:54
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
85% (-0.04% 🔻)
 5238/6162
🟡 Branches 66.64% 767/1151
🟡 Functions 75% 855/1140
🟢 Lines
84.9% (-0.05% 🔻)
 5019/5912
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🔴
... / transaction-response.ts
17.07% (-0.43% 🔻)
 0% 0%
17.5% (-0.45% 🔻)
🟢
... / constants.ts
96% (-0.15% 🔻)
 100% 0%
95.83% (-0.17% 🔻)
🔴
... / base-invocation-scope.ts
9.52% (-0.09% 🔻)
 0% 0%
9.62% (-0.09% 🔻)

Test suite run success

1253 tests passing in 216 suites.

Report generated by 🧪jest coverage report action from bdb4ca2

digorithm
digorithm approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @Dhaiwat10

@Dhaiwat10 Dhaiwat10 merged commit ddf1bd2 into master Oct 5, 2023
@Dhaiwat10 Dhaiwat10 deleted the dp/purge-max-inputs branch October 5, 2023 20:47
@github-actions github-actions bot mentioned this pull request Oct 5, 2023
Merged
camsjams
camsjams reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@camsjams camsjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I'm late to the party but still approve 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camsjams camsjams camsjams left review comments

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@digorithm digorithm digorithm approved these changes

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@Dhaiwat10 Dhaiwat10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Purge remaining hardcoded constants Dynamically fetch values of constants that rely on the environment
4 participants
@Dhaiwat10 @camsjams @digorithm @Torres-ssf