Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove verbose log #1323

Merged
merged 5 commits into from
Oct 10, 2023
Merged

fix: remove verbose log #1323

merged 5 commits into from
Oct 10, 2023

Conversation

camsjams
Copy link
Contributor

@camsjams camsjams commented Oct 7, 2023

Fixes #1322

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
85.05% (+0.01% 🔼)
5249/6172
🟡 Branches
66.84% (-0.03% 🔻)
776/1161
🟡 Functions
75.13% (+0.09% 🔼)
858/1142
🟢 Lines
84.93% (+0.01% 🔼)
5029/5921
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / provider.ts
61.9% (+0.09% 🔼)
50% (-0.67% 🔻)
59.7% (+1.49% 🔼)
62.96% (+0.11% 🔼)

Test suite run success

1262 tests passing in 216 suites.

Report generated by 🧪jest coverage report action from 88e998e

@camsjams camsjams enabled auto-merge (squash) October 7, 2023 04:49
Copy link
Contributor

@nedsalk nedsalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it should be noisy so that the user updates their package to the latest version, even if it's a patch version. Sorry, but I'll block this until @digorithm gives his thoughts, because this PR removes patch mismatch warnings altogether.

In the meantime, could you share with us the noisy logs and how they look?

@digorithm
Copy link
Member

IMO it should be noisy so that the user updates their package to the latest version, even if it's a patch version. Sorry, but I'll block this until @digorithm gives his thoughts, because this PR removes patch mismatch warnings altogether.

In the meantime, could you share with us the noisy logs and how they look?

Thanks @nedsalk, this is a thoughtful remark. However, patch versions in all repos maintained by Fuel Labs are supposed to be backward compatible, meaning: no breaking changes whatsoever. So a change from 0.x.1 to 0.x.2 should never cause any issue. Given that that's a thing, it doesn't make much sense for us to be noisy about it.

@digorithm digorithm requested a review from nedsalk October 9, 2023 19:12
@camsjams
Copy link
Contributor Author

An example of a mismatch log can be seen in here: #1322

But many TS-SDK developers will be iterating against the live node instead of local, so they'd see this constantly on their console @nedsalk :
image

@camsjams camsjams merged commit fec3f74 into master Oct 10, 2023
@camsjams camsjams deleted the cm/issue-1322 branch October 10, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fuel Client version check is too verbose
6 participants