-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove verbose log #1323
fix: remove verbose log #1323
Conversation
Coverage report
Show files with reduced coverage 🔻
Test suite run success1262 tests passing in 216 suites. Report generated by 🧪jest coverage report action from 88e998e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it should be noisy so that the user updates their package to the latest version, even if it's a patch version. Sorry, but I'll block this until @digorithm gives his thoughts, because this PR removes patch mismatch warnings altogether.
In the meantime, could you share with us the noisy logs and how they look?
Thanks @nedsalk, this is a thoughtful remark. However, patch versions in all repos maintained by Fuel Labs are supposed to be backward compatible, meaning: no breaking changes whatsoever. So a change from |
Fixes #1322