Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert graphql subscriptions PR #1333

Merged
merged 4 commits into from
Oct 11, 2023
Merged

fix: revert graphql subscriptions PR #1333

merged 4 commits into from
Oct 11, 2023

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Oct 10, 2023 •
edited
Loading

This PR reverts the changes done in #1256 due to #1298.

closes #1298.

After it is merged, I'll reopen #301, #782.

@nedsalk nedsalk enabled auto-merge (squash) October 10, 2023 18:20
@nedsalk nedsalk self-assigned this Oct 10, 2023
arboleya
arboleya reviewed Oct 10, 2023
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since none of the kept changes are critical, I'd prefer a full revert to avoid requesting everyone to review it again now thus speeding up the process to get it merged while simultaneously eliminating the risk of having potential new unknown-unknowns.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
84.78% (-0.26% 🔻)
 5232/6171
🟡 Branches
66.75% (-0.09% 🔻)
 771/1155
🟡 Functions
74.16% (-0.97% 🔻)
 858/1157
🟢 Lines
84.84% (-0.09% 🔻)
 5004/5898
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🔴
... / provider.ts
57.52% (-4.38% 🔻)
45.59% (-4.41% 🔻)
53.45% (-6.25% 🔻)
58.9% (-4.06% 🔻)
🟢
... / operations.ts
73.21% (-9.2% 🔻)
 100%
43.4% (-3.27% 🔻)
82.76% (+0.34% 🔼)

Test suite run success

1258 tests passing in 216 suites.

Report generated by 🧪jest coverage report action from e582050

@nedsalk nedsalk force-pushed the ns/revert-graphql-subscriptionsa branch from e79d37b to 46de200 Compare October 10, 2023 18:38
@nedsalk nedsalk marked this pull request as draft October 10, 2023 18:40
auto-merge was automatically disabled October 10, 2023 18:40

Pull request was converted to draft

@nedsalk nedsalk marked this pull request as ready for review October 10, 2023 19:12
@nedsalk nedsalk enabled auto-merge (squash) October 10, 2023 19:12
@nedsalk
Copy link
Contributor Author

nedsalk commented Oct 10, 2023

@arboleya I reverted it fully now.

@nedsalk nedsalk requested a review from arboleya October 10, 2023 19:13
@nedsalk nedsalk mentioned this pull request Oct 10, 2023
Closed
@nedsalk nedsalk merged commit bec5938 into master Oct 11, 2023
9 checks passed
@nedsalk nedsalk deleted the ns/revert-graphql-subscriptionsa branch October 11, 2023 09:38
@github-actions github-actions bot mentioned this pull request Oct 11, 2023
Merged
@nedsalk nedsalk mentioned this pull request Oct 25, 2023
Merged
@Torres-ssf Torres-ssf mentioned this pull request Dec 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbate danielbate danielbate approved these changes

@camsjams camsjams camsjams approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

Assignees

@nedsalk nedsalk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jest warns of potential open handles
4 participants
@nedsalk @arboleya @camsjams @danielbate