Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make SDK conform with Tx policies #1407

Merged
merged 314 commits into from
Dec 6, 2023
Merged

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Nov 6, 2023

Requirements

  • Update rust to version 1.73 — rustup update

This is necessary to build the latest forc from source.

Status

Test Suites: 254 passed, 254 total
Tests:       18 skipped, 1459 passed, 1477 total

Failing tests

  • apps/docs-snippets/src/guide/contracts/call-parameters.test.ts (fee-related)

  • packages/fuel-gauge/src/bytes.test.ts (predicate args using heap-types)
  • packages/fuel-gauge/src/contract.test.ts (fee-related)
  • packages/fuel-gauge/src/coverage-contract.test.ts (flaky, two tests using same wallet pvt key)
  • packages/fuel-gauge/src/fee.test.ts (fee-related)
  • packages/fuel-gauge/src/predicate/predicate-arguments.test.ts (predicate args using heap-types)
  • packages/fuel-gauge/src/predicate/predicate-invalidations.test.ts (fee-related)
  • packages/fuel-gauge/src/predicate/predicate-with-contract.test.ts (fee-related)
  • packages/fuel-gauge/src/predicate/predicate-with-script.test.ts (fee-related)
  • packages/fuel-gauge/src/raw-slice.test.ts (predicate args using heap-types)
  • packages/fuel-gauge/src/script-main-args.test.ts (fee-related)
  • packages/fuel-gauge/src/std-lib-string.test.ts (predicate args using heap-types)
  • packages/fuel-gauge/src/vector-types.test.ts (predicate args using heap-types)

  • packages/providers/test/provider.test.ts (pending version string)

  • packages/script/src/script.test.ts (args encoding problem)

  • packages/wallet/src/account.test.ts (fee-related)
  • packages/wallet/src/transfer.test.ts (fee-related)

  • packages/versions/scripts/rewriteVersions.test.ts (pending version string)
  • packages/versions/src/lib/getBuiltinVersions.test.ts (pending version string)

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
86.51% (+0.07% 🔼)
5981/6914
🟡 Branches
70.13% (+0.23% 🔼)
932/1329
🟡 Functions
77.43% (+0.31% 🔼)
988/1276
🟢 Lines
86.5% (+0.1% 🔼)
5730/6624
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / gas.ts
100% 100% 100% 100%
🟢
... / policy.ts
97.96% 91.67% 100% 97.87%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / provider.ts
55.08% (-1.59% 🔻)
46.51% (-4.21% 🔻)
50.85% (-0.88% 🔻)
56.22% (-1.72% 🔻)
🟢
... / assemble-transaction-summary.ts
88.24% (-11.76% 🔻)
35.29% (-21.85% 🔻)
50% (-50% 🔻)
90.91% (-9.09% 🔻)
🟢
... / utilities.ts
97.44% (-1.05% 🔻)
88.89% (-5.23% 🔻)
93.33% (+1.67% 🔼)
97.1% (-1.29% 🔻)
🟢
... / abi-coder.ts
92.5% (+0.19% 🔼)
84% (-2.36% 🔻)
87.5%
92.41% (+0.3% 🔼)
🟢
... / bn.ts
86.81% (-0.83% 🔻)
81.4% (-3.97% 🔻)
76.47% (-2.32% 🔻)
86.67% (-0.83% 🔻)
🟢
... / account.ts
88.75% (-2.05% 🔻)
55.56% (+10.1% 🔼)
92.31% (-0.55% 🔻)
88.75% (-2.05% 🔻)
🟢
... / transaction.ts
98.64% (-0.02% 🔻)
80% 100%
98.64% (-0.02% 🔻)
🟢
... / address.ts
89.47% (-1.64% 🔻)
58.33% (-8.33% 🔻)
82.35% (-0.98% 🔻)
89.47% (-1.64% 🔻)
🟢
... / utils.ts
90.38% (+0.19% 🔼)
84.21% (-1.5% 🔻)
92.31%
89.36% (+0.23% 🔼)
🟢
... / launchNode.ts
98.73% (-1.27% 🔻)
89.47% (-4.64% 🔻)
100%
98.67% (-1.33% 🔻)
🟡
... / hasher.ts
70.91% (-1.31% 🔻)
44.44% 100%
70.91% (-1.31% 🔻)
🔴
... / base-invocation-scope.ts
9.09% (-0.73% 🔻)
0% 0%
9.17% (-0.74% 🔻)

Test suite run success

1459 tests passing in 254 suites.

Report generated by 🧪jest coverage report action from e5aadee

@Torres-ssf

This comment was marked as resolved.

…ub.com:FuelLabs/fuels-ts into db/feat/represent-small-values-as-single-bytes
@Torres-ssf Torres-ssf changed the title chore: fuel core upgrade chore: make SDK conform with Tx policies Nov 16, 2023
@Torres-ssf Torres-ssf changed the base branch from master to beta-5 November 16, 2023 17:00
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question, guys: is this ready to go?

@Torres-ssf
Copy link
Contributor Author

Torres-ssf commented Dec 5, 2023

Quick question, guys: is this ready to go?

@digorithm Yep.

As soon as the new Forc version is released, we can release it as well

Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Torres-ssf Torres-ssf merged commit 2dd9d7a into beta-5 Dec 6, 2023
8 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/fuel-core-upgrade branch December 6, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make SDK to conform with new TX Policies
6 participants