Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TransactionRequest funding #1531

Merged
merged 14 commits into from
Dec 20, 2023
Merged

fix: TransactionRequest funding #1531

merged 14 commits into from
Dec 20, 2023

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf added the bug Issue is a bug label Dec 15, 2023
@Torres-ssf Torres-ssf self-assigned this Dec 15, 2023
@Torres-ssf Torres-ssf mentioned this pull request Dec 15, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 15, 2023 •
edited
Loading

This PR is published in NPM with version 0.0.0-pr-1531-20231219171623

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 15, 2023 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements
86.87% (-0.14% 🔻)
 6108/7031
🟡 Branches
70.86% (-0.56% 🔻)
 953/1345
🟡 Functions
77.79% (+0.03% 🔼)
 1005/1292
🟢 Lines
86.85% (-0.15% 🔻)
 5854/6740
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟡
... / transaction-request.ts
75% (-0.68% 🔻)
61.22% (-2.04% 🔻)
72.34% (+1.51% 🔼)
75% (-0.71% 🔻)
🟢
... / account.ts
80.56% (-8.47% 🔻)
30.43% (-15.02% 🔻)
88.24% (-4.62% 🔻)
80.56% (-8.47% 🔻)

Test suite run success

1476 tests passing in 260 suites.

Report generated by 🧪jest coverage report action from 49b195d

@Torres-ssf Torres-ssf marked this pull request as ready for review December 18, 2023 19:04
arboleya
arboleya previously approved these changes Dec 18, 2023
View reviewed changes
Dhaiwat10
Dhaiwat10 previously approved these changes Dec 19, 2023
View reviewed changes
.github/workflows/pr-release.yaml Outdated Show resolved Hide resolved
danielbate
danielbate previously approved these changes Dec 19, 2023
View reviewed changes
@Torres-ssf Torres-ssf dismissed stale reviews from Dhaiwat10 and danielbate via 1217514 December 19, 2023 16:57
@Torres-ssf Torres-ssf force-pushed the st/fix/get-transaction-cost-for-already-funded-tx branch from 1217514 to bbc9073 Compare December 19, 2023 17:02
@Torres-ssf Torres-ssf marked this pull request as draft December 19, 2023 17:34
LuizAsFight
LuizAsFight previously approved these changes Dec 19, 2023
View reviewed changes
@Torres-ssf Torres-ssf marked this pull request as ready for review December 19, 2023 23:15
@Torres-ssf Torres-ssf enabled auto-merge (squash) December 19, 2023 23:15
@Torres-ssf Torres-ssf merged commit 53dafb1 into master Dec 20, 2023
10 checks passed
@Torres-ssf Torres-ssf deleted the st/fix/get-transaction-cost-for-already-funded-tx branch December 20, 2023 08:46
@github-actions github-actions bot mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuizAsFight LuizAsFight LuizAsFight approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@luizstacio luizstacio Awaiting requested review from luizstacio

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on sending transaction with Message Input
5 participants
@Torres-ssf @arboleya @LuizAsFight @danielbate @Dhaiwat10