fix: contract created operation with input message #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizstacio
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate and
nedsalk
as code owners
Coverage report
Test suite run success1481 tests passing in 262 suites. Report generated by 🧪jest coverage report action from 53a914a |
arboleya
approved these changes
Jan 11, 2024
Torres-ssf
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
getContractCreatedOperationsonly checks by inputs of typeCoinwith the new implementation if accounts for coin and message.This issue is affecting also beta-4 versions, would be good to have a patch for the older versions also. But maybe as we don't have this support for now we are going to get it only on beta-5. cc: @arboleya
closes: #1634