Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bin installation from git #1667

Merged
merged 6 commits into from
Jan 22, 2024
Merged

fix: bin installation from git #1667

merged 6 commits into from
Jan 22, 2024

Conversation

arboleya
Copy link
Member

@arboleya arboleya commented Jan 19, 2024

1) Boken Commands

A couple of commands were broken, like:

import fs from 'fs/promises';

fs.rmSync(...);

But there's no <cmd>Sync() methods in fs/promises.

I also used the opportunity to standardize a couple of things.

2) Problematic tar package

I had problems with the TAR package, saying the tar files were invalid.

Since we won't support Windows soon, I removed them and rolled back the original commands.

@arboleya arboleya added the bug Issue is a bug label Jan 19, 2024
@arboleya arboleya added this to the 2 - Beetle milestone Jan 19, 2024
@arboleya arboleya self-assigned this Jan 19, 2024
Torres-ssf
Torres-ssf previously approved these changes Jan 19, 2024
Copy link
Contributor

github-actions bot commented Jan 19, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 86.91% 6159/7087
🟡 Branches 70.9% 965/1361
🟡 Functions 77.95% 1011/1297
🟢 Lines 86.89% 5903/6794

Test suite run success

1482 tests passing in 263 suites.

Report generated by 🧪jest coverage report action from 295d8a2

Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't approve, but looks good 💯

@arboleya arboleya enabled auto-merge (squash) January 22, 2024 09:35
Copy link
Member

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@arboleya arboleya merged commit 261c641 into master Jan 22, 2024
12 checks passed
@arboleya arboleya deleted the aa/fix/bin-install-from-git branch January 22, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants