-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove additional dryrun call #1731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicts to fix.
Coverage Report:
Changed Files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this after sync with @Torres-ssf around this comment. We'll create a separate issue around it after we flesh it out.
This PR intends to remove a
dryRun
call that happens before sending the transaction that has the only purpose of validating if thegasLimit
orgasPrice
is enough for the transaction to be processed.Since these 2 validations can be done without an additional dryRun call we can safely remove it.