Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove additional dryrun call #1731

Merged
merged 17 commits into from
Feb 14, 2024

Conversation

Torres-ssf
Copy link
Contributor

This PR intends to remove a dryRun call that happens before sending the transaction that has the only purpose of validating if the gasLimit or gasPrice is enough for the transaction to be processed.

Since these 2 validations can be done without an additional dryRun call we can safely remove it.

@Torres-ssf Torres-ssf added the chore Issue is a chore label Feb 9, 2024
@Torres-ssf Torres-ssf self-assigned this Feb 9, 2024
@Torres-ssf Torres-ssf changed the title St/chore/remove additional dryrun call chore: remove additional dryrun call Feb 9, 2024
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts to fix.

@Torres-ssf Torres-ssf enabled auto-merge (squash) February 14, 2024 13:15
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.79%(-0.03%) 70.15%(-0.16%) 79.07%(-0.06%) 79.84%(-0.03%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/account.ts 80.17%
(+0.17%)
48.88%
(+9.86%)
90%
(+0.53%)
80.17%
(+0.17%)
🔴 packages/account/src/providers/provider.ts 80.93%
(-0.43%)
66.37%
(-2.53%)
86.15%
(+0%)
81.5%
(-0.41%)
🔴 packages/account/src/providers/transaction-request/script-transaction-request.ts 40%
(-2.5%)
57.14%
(+0%)
33.33%
(-5.55%)
39.02%
(-2.44%)
🔴 packages/account/src/providers/utils/receipts.ts 94.44%
(+0%)
80%
(-3.33%)
100%
(+0%)
94.54%
(+0%)

Copy link
Contributor

@nedsalk nedsalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this after sync with @Torres-ssf around this comment. We'll create a separate issue around it after we flesh it out.

@Torres-ssf Torres-ssf merged commit 1a607fa into master Feb 14, 2024
20 of 22 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/remove-additional-dryrun-call branch February 14, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants