Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support encoding/decoding of larger contract bytecodes #1783

Merged
merged 12 commits into from
Feb 22, 2024

Conversation

jasmcaus
Copy link
Contributor

@jasmcaus jasmcaus commented Feb 21, 2024

Big thanks to @jasmcaus who experienced a problem, analyzed the issue and solved it with this PR!

We extended this PR to solve more specs discrepancies that we found while analyzing the initial problem/solution @jasmcaus presented.
closes #1785.

@CLAassistant
Copy link

CLAassistant commented Feb 21, 2024

CLA assistant check
All committers have signed the CLA.

@jasmcaus jasmcaus changed the title fix: support encoding of larger contract bytecodes fix: support encoding/decoding of larger contract bytecodes Feb 21, 2024
@arboleya arboleya added the bug Issue is a bug label Feb 21, 2024
@arboleya
Copy link
Member

arboleya commented Feb 21, 2024

Hi @jasmcaus, thank you for your contribution!

I believe you found a minor discrepancy in the specs here and here.

Please, allow us to review some things and get back to you.

@Dhaiwat10
Copy link
Member

Thanks @jasmcaus and @nedsalk :)

@nedsalk nedsalk merged commit de22b73 into FuelLabs:master Feb 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update encoding/decoding according to new specs
6 participants