chore: replace ethers implementations of sha256, scrypt and keccak
#1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/chore/replace-ethers-hashing-algos
danielbate
changed the title
ethers hashing algorithmsethers implementations of sha256, scrypt and keccak
…/chore/replace-ethers-hashing-algos
danielbate
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10 and
nedsalk
as code owners
|
Coverage Report:
Changed Files:Coverage values did not change👌. |
arboleya
approved these changes
Mar 5, 2024
nedsalk
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from discussions in #1592 to deprecate
ethers, this PR replaces the hashing algorithms with a tree-shakable alternative @noble/hashes.In this PR
sha256,scryptandkeccakhave been replaced.