-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: support v1
encoding in program types
#1832
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/feat/support-v1-encoding
…/feat/support-v1-encoding
…/feat/support-v1-encoding
…/feat/support-v1-encoding
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
petertonysmith94
previously approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTG 🍏
Dhaiwat10
previously approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 🔥 Excellent work
Torres-ssf
previously approved these changes
Apr 4, 2024
danielbate
dismissed stale reviews from Dhaiwat10, Torres-ssf, and petertonysmith94
via
April 4, 2024 14:30
12e725c
Coverage Report:
Changed Files:
|
petertonysmith94
approved these changes
Apr 4, 2024
Dhaiwat10
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1739
Closes #1749
v1
decode in scriptsv1
encode in scriptsv1
encode/decode in predicatesv1
encode/decode in contractsThis PR is using
forc@0.52.1
for our experimental forc version.#1187 is currently blocked sway side and will be supported later.
Breaking change:
When building projects using
--experimental-new-encoding
, calls to program types are now parsed using the new encoding scheme. As the flag suggests, this is currently experimental and should be treated as so. Calls using a string slice and nested heaps no longer throw.