fix: remove unused dependency fuels from the create-fuels package
#2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhaiwat10
changed the title
fuels from the create-fuels package
Dhaiwat10
changed the title
fuels from the create-fuels packagefuels from the create-fuels package
|
This PR is published in NPM with version 0.0.0-pr-2019-20240405203944 |
Dhaiwat10
requested review from
digorithm,
arboleya,
Torres-ssf,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
|
Coverage Report:
Changed Files:Coverage values did not change👌. |
|
Good find @Dhaiwat10 , but we probably should integrate a tool like depcheck into our CI to see what other unused dependencies are polluting the repo and ensure they are removed before being merged. |
petertonysmith94
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Approved 🍏
I agree with @maschad about the dependency check in the CI - I would say this could be follow up issue.
arboleya
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We had
fuelslisted in the dependencies forcreate-fuelseven though we were not using it, and this was causing the initial install/execution of thepnpm create fuelscommand to be extremely slow. Now it's almost instant :DCloses #2013