-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: remove built-in binaries for forc
and fuel-core
#2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertonysmith94
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
nedsalk and
maschad
as code owners
April 23, 2024 07:49
nedsalk
previously approved these changes
Apr 23, 2024
petertonysmith94
dismissed
nedsalk’s stale review
April 23, 2024 12:48
Furthering the scope of this review, so dismissing review :)
…/docs/undocument-binaries
…/docs/undocument-binaries
arboleya
reviewed
Apr 23, 2024
danielbate
previously approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arboleya
reviewed
May 20, 2024
Coverage Report:
Changed Files:
|
Dhaiwat10
approved these changes
May 20, 2024
danielbate
approved these changes
May 21, 2024
arboleya
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2084
Closes #2277
Summary
forc
andfuel-core
binaries (removed usage for end-consumer).forcPath
andfuelCorePath
to thefuels.config.ts
.forc
andfuel-core
fuels
CLI.Breaking change
forc
orfuel-core
are not available.Suggested to install
fuelup
and associated binaries (forc
andfuel-core
).fuels.config
- removed optionsuseBuiltinForc
anduseBuiltinFuelCore
launchNode
- removed option foruseSystemFuelCore
Scenarios
Both instances will stop the process until the issue/s are resolved.