-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add debug logger for fuel-ts ecosystem #2366
Conversation
823f8fb
to
d7fc2a4
Compare
Maybe if we decide to add more complex loggers but given these are just singular functions having a folder just for a function seems a bit overkill. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🍏 🚀
Coverage Report:
Changed Files:
|
@maschad Should this have been a breaking change? If yes, please describe it in the PR description. |
@arboleya the validate changesets workflow treated this as a breaking change in our current release process (see #2366 (comment)) Upon further discussion in the 24-06-2024 Sync I have updated the PR title on the recommendation from @nedsalk so that the release PR has not mentioned it as breaking. |
@maschad You changed the title after the merge, and although it looks right in the changeset PR (not a breaking), you can see that it is still considered a minor bump because the changeset remains the same - with the Finally, I think it should still be a
|
@arboleya you're right, the changeset should be changed manually, there's no workaround for that. sigh I can't wait for the day when a singular |
* chore: added initial logger * docs: add changeset * fix: added enginge to package.json * docs: updated changeset * test: add more tests * build: undo coverage changes * feat: fix build issues * feat: update BN formatter * build: update lockfile * test: add more tests * docs: update changeset * test: add test environment config * test: remove browser testing * docs: revert changeset * test: add formatter tests
A simple logger for our packages. This is particularly useful when debugging BNs, Hexs, Addresses and other types that are common in transactions and bytecode. Below is an example of a formatted BN when debugging the calculateTXFeeForSummary function.
Closes #2298