Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document the SDKs approach to encoding #2405

Merged
merged 24 commits into from
Jun 11, 2024
Merged

docs: document the SDKs approach to encoding #2405

merged 24 commits into from
Jun 11, 2024

Conversation

danielbate
Copy link
Member

Closes #907

@danielbate danielbate added the docs Requests pertinent to documentation label May 28, 2024
@danielbate danielbate self-assigned this May 28, 2024
@danielbate danielbate marked this pull request as ready for review May 28, 2024 15:04
Torres-ssf
Torres-ssf previously approved these changes May 28, 2024
View reviewed changes
arboleya

This comment was marked as resolved.

Sign in to view

petertonysmith94
petertonysmith94 reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits

apps/docs-snippets/test/fixtures/forc-projects/sum-script/src/main.sw Outdated Show resolved Hide resolved
apps/docs-snippets/src/guide/encoding/encode-and-decode.test.ts Outdated Show resolved Hide resolved
apps/docs-snippets/src/guide/encoding/encode-and-decode.test.ts Outdated Show resolved Hide resolved
maschad
maschad suggested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy to see this it will prove quite useful, I think we can be guided what has been documented in the Rust SDK so that we have more consistency in the docs.

apps/docs-snippets/src/guide/encoding/encode-and-decode.test.ts Outdated Show resolved Hide resolved
apps/docs/src/guide/encoding/encode-and-decode.md Outdated Show resolved Hide resolved
@danielbate danielbate requested review from maschad and Torres-ssf June 9, 2024 16:10
@danielbate @petertonysmith94
chore: use context
a52a596 
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
danielbate and others added 9 commits June 11, 2024 09:44
petertonysmith94
petertonysmith94 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dreamy 📗

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
45.41%(+0%) 38.46%(+0%) 42.19%(+0%) 45.18%(+0%)
Changed Files:

Coverage values did not change👌.

maschad
maschad approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

arboleya
arboleya approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚢

@danielbate danielbate merged commit 439d0dc into master Jun 11, 2024
20 checks passed
@danielbate danielbate deleted the db/docs/encoding-documentation branch June 11, 2024 13:36
@fuel-service-user fuel-service-user mentioned this pull request Jun 11, 2024
Merged
@danielbate danielbate added this to the 0.x mainnet milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@maschad maschad maschad approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

Assignees

@danielbate danielbate

Labels
docs Requests pertinent to documentation
Projects
None yet
Milestone
0.x mainnet
Development

Successfully merging this pull request may close these issues.

Document how the abi-coder package works
5 participants
@danielbate @arboleya @maschad @petertonysmith94 @Torres-ssf