-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: separate onSuccess
events for the Fuels CLI
#2433
feat!: separate onSuccess
events for the Fuels CLI
#2433
Conversation
build
and deploy
events during fuels dev
onSuccess
events for the Fuels CLI
✨ A PR has been created under the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering whether we should update the onFailure
method to match the new listener format...
onFailure?: (event: Error, config: FuelsConfig) => void;
to
onFailure?: (config: FuelsConfig, event: Error) => void;
@arboleya What do you think?
Edit: I'm doing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🎯
Coverage Report:
Changed Files:
|
build
anddeploy
events duringfuels dev
#2423Breaking change
createConfig
now has individual hooks for allfuels
CLI events types.onFailure
hook increateConfig
.