-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add version detection to create fuels
#2524
chore: add version detection to create fuels
#2524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the e2es are still failing.
@arboleya apologies was mean't to be a draft! I had to think on the solution. |
This PR is published in NPM with version 0.0.0-pr-2524-20240616055234 |
create fuels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits.
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM — Later on, I'd like to review the overall approach tho.
I feel I'm a bit out of context.
Coverage Report:
Changed Files:
|
Fixing e2e test that is failing.