-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add UNKNOWN
error code
#2562
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maschad
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
nedsalk and
petertonysmith94
as code owners
June 20, 2024 03:42
maschad
changed the title
chore: added
chore: add Jun 20, 2024
UNKNOWN
error codeUNKNOWN
error code
danielbate
previously approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arboleya
reviewed
Jun 20, 2024
@petertonysmith94 Almost, but not 100%. The latter also requires the addition of the |
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
Co-authored-by: Anderson Arboleya <anderson@arboleya.me>
petertonysmith94
previously approved these changes
Jun 21, 2024
arboleya
requested changes
Jun 21, 2024
arboleya
previously approved these changes
Jun 22, 2024
Torres-ssf
previously approved these changes
Jun 24, 2024
petertonysmith94
approved these changes
Jun 24, 2024
Torres-ssf
approved these changes
Jun 24, 2024
arboleya
approved these changes
Jun 24, 2024
Coverage Report:
Changed Files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unknown
Error Code #2470UNKNOWN
error code andrawError
property toFuelError
#2521This is the only specific use case I can currently see in the codebase. I'm not sure if any other error handling use cases apply at the moment @Torres-ssf