Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to NextJS app router #2580

Merged

Conversation

YaTut1901
Copy link
Contributor

@YaTut1901 YaTut1901 commented Jun 22, 2024

@YaTut1901
Copy link
Contributor Author

hello, can anybody suggest how to solve those conflicts? I am checking the branch and it is up to date with master

@arboleya arboleya added the feat Issue is a feature label Jun 23, 2024
@arboleya arboleya added this to the 0.x mainnet milestone Jun 23, 2024
Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated Fork

hello, can anybody suggest how to solve those conflicts? I am checking the branch and it is up to date with master

Your fork/branch is evidently not up to date with master; otherwise, there wouldn't be conflicts.

outdated

You seem to lack basic knowledge of how Git and GitHub work, which makes it hard for you to contribute to open-source projects. It would be best if you improved on that.

Sync Remote

First, you must synchronize your fork — you can do this even using the UI.

sync

Update Local

From there, you can:

cd you/local/repo

# fetch updates from your synchronized repo/fork
git pull origin master

# checkout to your feature branch
git checkout feature/app-router-nextjs

# apply new changes from master — requires resolving the conflicts
git merge master

# push the updated branch to your remote
git push origin feature/app-router-nextjs

Not enough?

If even that doesn't sound straightforward, you can re-do everything:

  • Delete your local feature branch
  • Start a new one from [your updated] master
  • Re-apply your changes, push, and open a new PR

Final Notes

I recommend studying GIT.

We may not be able to help you with that.

@YaTut1901
Copy link
Contributor Author

yes, seems like that is a gap in my knowledge, thanks for pointing it out

@petertonysmith94 petertonysmith94 dismissed their stale review June 24, 2024 06:47

Premature approval

@YaTut1901 YaTut1901 changed the title NextJS app router migration feat: migrate to NextJS app router Jun 24, 2024
@petertonysmith94
Copy link
Contributor

Thank you for you contribute @YaTut1901 - we appreciate it!

@YaTut1901
Copy link
Contributor Author

Thank you for you contribute @YaTut1901 - we appreciate it!

Thank you for your advices! BTW, is there anything other in scope of your projects I can help with?

@petertonysmith94
Copy link
Contributor

Thank you for you contribute @YaTut1901 - we appreciate it!

Thank you for your advices! BTW, is there anything other in scope of your projects I can help with?

You're more than welcome!
I was going to suggest #2613 - but I can see you have already spied it 😄

Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@petertonysmith94 petertonysmith94 enabled auto-merge (squash) June 26, 2024 09:01
@petertonysmith94 petertonysmith94 merged commit c846bfb into FuelLabs:master Jun 26, 2024
28 checks passed
@YaTut1901 YaTut1901 deleted the YaTut1901/feature/app-router-nextjs branch June 26, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Next.js v14 resources in create fuels template
5 participants