Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: upgrade commander to12.1.0 #2620

Merged
merged 6 commits into from
Jun 26, 2024
Merged

chore!: upgrade commander to12.1.0 #2620

merged 6 commits into from
Jun 26, 2024

Conversation

YaTut1901
Copy link
Contributor

@YaTut1901 YaTut1901 commented Jun 25, 2024 •
edited by nedsalk
Loading

Breaking Changes:

The shorthand flag (-p) for passing through a path to various fuels CLI commands has been deprecated. Migrate to using the --path flag instead.

@maschad maschad changed the title fix(fuels): removed -p flag, bumped commander dep to latest chore: upgrade commander to12.1.0 Jun 25, 2024
@github-actions github-actions bot added the chore Issue is a chore label Jun 25, 2024
@maschad maschad changed the title chore: upgrade commander to12.1.0 chore!: upgrade commander to12.1.0 Jun 25, 2024
@maschad maschad marked this pull request as draft June 25, 2024 20:03
@maschad
Copy link
Member

maschad commented Jun 25, 2024

Thanks for opening this @YaTut1901 , I've converted this to a draft PR. Feel free to re-open once the CI tests are passing.

@YaTut1901 YaTut1901 marked this pull request as ready for review June 26, 2024 08:03
petertonysmith94
petertonysmith94 reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth making the breaking change description a little bit more descriptive:

The shorthand flag (-p) for passing through a path to various fuels CLI commands has been deprecated. Migrate to using the --path flag instead.

@petertonysmith94 petertonysmith94 added this to the 0.x mainnet milestone Jun 26, 2024
petertonysmith94
petertonysmith94 previously approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@petertonysmith94 petertonysmith94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the condition of the description being updated 😄

Nice work @YaTut1901 🔥

@YaTut1901
Copy link
Contributor Author

Worth making the breaking change description a little bit more descriptive:

The shorthand flag (-p) for passing through a path to various fuels CLI commands has been deprecated. Migrate to using the --path flag instead.

do you mean description in PR?

nedsalk
nedsalk previously approved these changes Jun 26, 2024
View reviewed changes
@petertonysmith94
Copy link
Contributor

Worth making the breaking change description a little bit more descriptive:

The shorthand flag (-p) for passing through a path to various fuels CLI commands has been deprecated. Migrate to using the --path flag instead.

do you mean description in PR?

Correct 🔥

@YaTut1901 @petertonysmith94
Update .changeset/seven-moles-live.md
d5546c6 
Co-authored-by: Peter Smith <peter@blueoceancomputing.co.uk>
@YaTut1901 YaTut1901 dismissed stale reviews from nedsalk and petertonysmith94 via d5546c6 June 26, 2024 11:42
@petertonysmith94
Copy link
Contributor

Failing due to the following check:
Release to @rc-<pr_number> tag on npm / Release breaking change PR to npm (pull_request) (source).

Will merge anyway as I don't see any breaking change for the wallet here.

@petertonysmith94 petertonysmith94 merged commit a6c45fd into FuelLabs:master Jun 26, 2024
20 of 21 checks passed
@fuel-service-user fuel-service-user mentioned this pull request Jun 26, 2024
Merged
@arboleya arboleya mentioned this pull request Jun 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedsalk nedsalk nedsalk approved these changes

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@YaTut1901 YaTut1901

Labels
chore Issue is a chore
Projects
None yet
Milestone
0.x mainnet
Development

Successfully merging this pull request may close these issues.

Upgrade commander dependency
5 participants
@YaTut1901 @maschad @petertonysmith94 @danielbate @nedsalk