-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: implement a helper createAssetId function #2665
chore: implement a helper createAssetId function #2665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bolajahmad, thankyou for the contribution!
I've suggested some structural changes that'll bring this more inline with the SDK.
You also need to add a changeset (run pnpm changeset
on the root directory) which will need a patch
change for the transactions
package.
Please also make your PR title more complete, as it is no longer in draft. I'd also suggest the following title:
feat: add
createAssetId
utility function
Be sure to add the PR title exactly to the changeset. Let us know if you need any additional support.
cbb898c
to
075ef73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bolajahmad It seems the issue #2646 was closed by @matt-user.
But we can use the opportunity to improve this Doc page.
ba6dbc4
to
9a24fdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thought on the snippet
apps/docs-snippets/src/guide/contracts/minted-token-asset-id.test.ts
Outdated
Show resolved
Hide resolved
Please add |
39d597e
to
8504c3a
Compare
apps/docs-snippets/src/guide/contracts/minted-token-asset-id.test.ts
Outdated
Show resolved
Hide resolved
…eate-assetid-helper-fn
Release notes
In this release, we:
createAssetId
function to create a nativeAssetId
typeSummary
This PR implements the helper
createAssetId
, which will receive as parameters a contract ID and a sub-asset ID and will return the Sway native parameter AssetIdChecklist
tests
to prove my changesdocs