-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make properties of configurables optional in typegen #2815
fix: make properties of configurables optional in typegen #2815
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left two comments
packages/fuel-gauge/src/predicate/predicate-configurables.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR currently only solves the problem for predicates, but #2790 is a general issue that includes scripts and contracts as well, so they should be covered in this PR also.
c7117fc
Coverage Report:
Changed Files:
|
Summary
This PR updates the typegen template to ensure that all configurable properties are optional.
Checklist
tests
to prove my changesdocs