Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make properties of configurables optional in typegen #2815

Merged
merged 10 commits into from
Jul 23, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Jul 22, 2024

Summary

This PR updates the typegen template to ensure that all configurable properties are optional.

Checklist

  • I addedtests to prove my changes
  • I updated — all the necessary docs
  • I reviewed — the entire PR myself, using the GitHub UI
  • I described — all breaking changes and the Migration Guide

arboleya
arboleya previously approved these changes Jul 22, 2024
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left two comments

maschad
maschad previously approved these changes Jul 22, 2024
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@nedsalk nedsalk self-requested a review July 23, 2024 07:38
Copy link
Contributor

@nedsalk nedsalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR currently only solves the problem for predicates, but #2790 is a general issue that includes scripts and contracts as well, so they should be covered in this PR also.

.changeset/tasty-fireants-switch.md Outdated Show resolved Hide resolved
@Torres-ssf Torres-ssf dismissed stale reviews from petertonysmith94 and maschad via c7117fc July 23, 2024 13:25
@Torres-ssf Torres-ssf changed the title fix: make Predicate configurables option in typegen fix: make properties of configurables optional in typegen Jul 23, 2024
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.4%(+0.04%) 71.53%(-0.12%) 77.32%(+0.02%) 79.53%(+0.04%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/account.ts 82.31%
(+1.16%)
65.07%
(+1.14%)
82.35%
(+0.54%)
82%
(+1.15%)
🔴 packages/account/src/providers/provider.ts 68.02%
(-0.82%)
62.63%
(-1.19%)
73.49%
(-0.31%)
67.98%
(-0.81%)
🔴 packages/account/src/test-utils/launchNode.ts 98.27%
(+0.01%)
85.24%
(+0.5%)
100%
(+0%)
98.36%
(+0.02%)
🔴 packages/contract/src/contract-factory.ts 58.33%
(-0.29%)
46.42%
(+0.27%)
54.54%
(+0%)
58.33%
(-0.29%)
🔴 packages/contract/src/util.ts 93.75%
(+0.42%)
0%
(+0%)
66.66%
(+0%)
88.88%
(+0.65%)
🔴 packages/create-fuels/src/cli.ts 85.5%
(+0.21%)
37.5%
(-2.5%)
100%
(+0%)
85.5%
(+0.21%)

@arboleya arboleya removed the p1 label Jul 23, 2024
@Torres-ssf Torres-ssf merged commit 5b670a5 into master Jul 23, 2024
24 of 25 checks passed
@Torres-ssf Torres-ssf deleted the st/fix/make-predicate-configurables-partial branch July 23, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make configurable properties optional in typegen outputs
5 participants