fix: typegen generic configurables #2859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedsalk
requested review from
digorithm,
arboleya,
Torres-ssf,
Dhaiwat10,
danielbate,
petertonysmith94 and
maschad
as code owners
packages/abi-typegen/test/fixtures/forc-projects/minimal-with-configurable/src/main.sw
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@Torres-ssf it is done via packages/abi-typegen/test/fixtures/templates/contract-with-configurable/dts.hbs. I changed the expected generated code. The test that's verifying the output matches this file's contents is this one. I didn't have to change the test, just the expected output and then implement the fix so that the typegen output matches it. |
Torres-ssf
approved these changes
Jul 30, 2024
petertonysmith94
approved these changes
Jul 30, 2024
maschad
approved these changes
Jul 30, 2024
|
Coverage Report:
Changed Files:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the problem reported in the issue and refactored the code a bit.
Checklist
teststo prove my changesdocs